Implement Global EventList Support #24862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
|
PR #24862: Size comparison from 655d134 to dda3921 Increases above 0.2%:
Increases (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap
Outdated
Show resolved
Hide resolved
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap
Outdated
Show resolved
Hide resolved
|
PR #24862: Size comparison from 655d134 to 59be2e9 Increases above 0.2%:
Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (12 builds for bl702, cc13x2_26x2, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap examples/bridge-app/bridge-common/bridge-app.zap examples/lock-app/lock-common/lock-app.zap scripts/tools/zap/tests/inputs/all-clusters-app.zap scripts/tools/zap/tests/inputs/lighting-app.zap Note that all-clusters-minimal-app.zap enables only minimally required Events. All other updated ZAP files enable all mandatory and optional Events required by the defined Feature Map.
I Reverted Changes to ZAP files. Only updated the following ZAP files: Note that all-clusters-minimal-app.zap enables only minimally required Events. |
andy31415
requested changes
Feb 6, 2023
There was a problem hiding this comment.
@emargolis I would have expected that the global event list change to show up in .matter files. Without that, codegen based on matter would not have access to the same information as .zap files.
Why is it not showing up?
As an example, if you look at lightingapp.matter, it contains things like: so global attributes are expected to show up. |
@andy31415 I see that currently there is no consistency between *.matter and *.zap files and no clear understanding if Global attributes (GeneratedCommandList, AcceptedCommandList, EventList, AttributeList) should be included in these files. I suggest we deal with that in a follow up PR. |
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
…s Examples. This event is never emitted. Also run ZAP REGEN.
bzbarsky-apple
approved these changes
Feb 7, 2023
andy31415
approved these changes
Feb 7, 2023
andy31415
reviewed
Feb 7, 2023
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Feb 13, 2023
* Global Event List Support: All Manually Updated Files * Manually updated all *.zap files to include events for all clusters that have them. For each ZAP file was running ./scripts/tools/zap/run_zaptool.sh manually. * Automatically generated files. By running ./scripts/tools/zap_regen_all.py script. * Updated ZAP version to v2023.02.03-nightly * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updated all-clusters-minimal-app.zap to Include Only Minimul Number of Required Event. Exclude all optional events. * Updated TestAttributePathExpandIterator.cpp test * Add voided use of generatedEvents to prevent unused variable error when array is empty * Updated TestBasicInformation.yaml to support EventList * Rerun ZAP REGEN * Updated YAML tests to include EventList Attribute * ZAP REGEN * restyled * Reverted Changes to ZAP files. Only updated the following ZAP files: examples/all-clusters-app/all-clusters-common/all-clusters-app.zap examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap examples/bridge-app/bridge-common/bridge-app.zap examples/lock-app/lock-common/lock-app.zap scripts/tools/zap/tests/inputs/all-clusters-app.zap scripts/tools/zap/tests/inputs/lighting-app.zap Note that all-clusters-minimal-app.zap enables only minimally required Events. All other updated ZAP files enable all mandatory and optional Events required by the defined Feature Map. * ZAP REGEN * Removed ReachableChanged Basic Information Cluster Event from all Apps Examples. This event is never emitted. Also run ZAP REGEN. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Global Event List Support: All Manually Updated Files * Manually updated all *.zap files to include events for all clusters that have them. For each ZAP file was running ./scripts/tools/zap/run_zaptool.sh manually. * Automatically generated files. By running ./scripts/tools/zap_regen_all.py script. * Updated ZAP version to v2023.02.03-nightly * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updated all-clusters-minimal-app.zap to Include Only Minimul Number of Required Event. Exclude all optional events. * Updated TestAttributePathExpandIterator.cpp test * Add voided use of generatedEvents to prevent unused variable error when array is empty * Updated TestBasicInformation.yaml to support EventList * Rerun ZAP REGEN * Updated YAML tests to include EventList Attribute * ZAP REGEN * restyled * Reverted Changes to ZAP files. Only updated the following ZAP files: examples/all-clusters-app/all-clusters-common/all-clusters-app.zap examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap examples/bridge-app/bridge-common/bridge-app.zap examples/lock-app/lock-common/lock-app.zap scripts/tools/zap/tests/inputs/all-clusters-app.zap scripts/tools/zap/tests/inputs/lighting-app.zap Note that all-clusters-minimal-app.zap enables only minimally required Events. All other updated ZAP files enable all mandatory and optional Events required by the defined Feature Map. * ZAP REGEN * Removed ReachableChanged Basic Information Cluster Event from all Apps Examples. This event is never emitted. Also run ZAP REGEN. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: All manually updated files required to support Global EventList feature
Second commit: Manually updated all *.zap files in the CHIP repo to include events information. The process was manual by running ./scripts/tools/zap/run_zaptool.sh tool for each *.zap file then finding and enabling each event individually - very annoying :)
Third commit: Run ZAP REGEN tool
Fourth commit: Updated ZAP version to
v2023.02.03-nightlyThese changes are related to the changes in ZAP repo:
project-chip/zap#914
Fixes: #15011